From: Eugene Syromiatnikov Date: Mon, 27 Oct 2025 09:17:57 +0000 (+0100) Subject: doc/man3/X509_STORE_get0_param.pod: mention how to free the returned objects X-Git-Tag: 4.0-PRE-CLANG-FORMAT-WEBKIT~208 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de1abbed1cd75fcb8a6becadbc2854aa124f9bcf;p=thirdparty%2Fopenssl.git doc/man3/X509_STORE_get0_param.pod: mention how to free the returned objects It is not entirely obvious from the description how the objects returned by X509_STORE_get1_objects() and X509_STORE_get1_all_certs() are supposed to be freed, explicitly mention the relevant calls, and provide a reference to DEFINE_STACK_OF(3). Signed-off-by: Eugene Syromiatnikov Reviewed-by: Saša Nedvědický Reviewed-by: Todd Short (Merged from https://github.com/openssl/openssl/pull/29002) --- diff --git a/doc/man3/X509_STORE_get0_param.pod b/doc/man3/X509_STORE_get0_param.pod index d9cab04d1c8..cb0cd40d9d7 100644 --- a/doc/man3/X509_STORE_get0_param.pod +++ b/doc/man3/X509_STORE_get0_param.pod @@ -25,8 +25,9 @@ parameters for I. The returned pointer must not be freed by the calling application X509_STORE_get1_objects() returns a snapshot of all objects in the store's X509 -cache. The cache contains B and B objects. The caller is -responsible for freeing the returned list. +cache. The cache contains B and B objects. The caller +is responsible for freeing the returned list, +using sk_X509_OBJECT_pop_free(sk, X509_OBJECT_free). X509_STORE_get0_objects() was deprecated in OpenSSL 4.0. Applications should instead use X509_STORE_get1_objects() to avoid potential @@ -41,7 +42,8 @@ required to acquire the store lock via X509_STORE_lock() before invoking X509_STORE_get0_objects(). X509_STORE_get1_all_certs() returns a list of all certificates in the store. -The caller is responsible for freeing the returned list. +The caller is responsible for freeing the returned list +with OSSL_STACK_OF_X509_free(). =head1 RETURN VALUES @@ -60,6 +62,7 @@ certificates on success, else NULL. =head1 SEE ALSO +L, L =head1 HISTORY