From: H.J. Lu <hjl.tools@gmail.com>
Date: Fri, 7 Sep 2012 21:14:08 +0000 (-0700)
Subject: Check if deriv->steps is NULL before freeing it
X-Git-Tag: glibc-2.17~563
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de2139a9f25d8f7fb76f260fe7cc86ffd736a5d9;p=thirdparty%2Fglibc.git

Check if deriv->steps is NULL before freeing it
---

diff --git a/ChangeLog b/ChangeLog
index 6d3823ec78a..77ae95cff6b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2012-09-07  H.J. Lu  <hongjiu.lu@intel.com>
 
+	* iconv/gconv_db.c (free_derivation): Check if deriv->steps
+	is NULL.
+
 	* debug/Makefile (LDFLAGS-tst-chk4): Renamed to ...
 	(LDLIBS-tst-chk4): This.
 	(LDFLAGS-tst-chk5): Renamed to ...
diff --git a/iconv/gconv_db.c b/iconv/gconv_db.c
index a081205106e..5bc7ff8bd08 100644
--- a/iconv/gconv_db.c
+++ b/iconv/gconv_db.c
@@ -193,10 +193,13 @@ free_derivation (void *p)
       }
 
   /* Free the name strings.  */
-  free ((char *) deriv->steps[0].__from_name);
-  free ((char *) deriv->steps[deriv->nsteps - 1].__to_name);
+  if (deriv->steps != NULL)
+    {
+      free ((char *) deriv->steps[0].__from_name);
+      free ((char *) deriv->steps[deriv->nsteps - 1].__to_name);
+      free ((struct __gconv_step *) deriv->steps);
+    }
 
-  free ((struct __gconv_step *) deriv->steps);
   free (deriv);
 }