From: Mark Adler <madler@alumni.caltech.edu>
Date: Sun, 20 Nov 2011 16:43:46 +0000 (-0800)
Subject: Remove code from inflate.c and infback.c that is impossible to execute.
X-Git-Tag: v1.2.5.2~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de32a2d74948e13e4d8ec17263a31e2c3ae900b1;p=thirdparty%2Fzlib-ng.git

Remove code from inflate.c and infback.c that is impossible to execute.

During coverage testing it was discovered that these two lines could
never pull more bits, since the immediately preceding for loop assures
that all of the code's bits are already pulled.
---

diff --git a/infback.c b/infback.c
index 546295261..c02648543 100644
--- a/infback.c
+++ b/infback.c
@@ -403,7 +403,6 @@ void FAR *out_desc;
                     PULLBYTE();
                 }
                 if (here.val < 16) {
-                    NEEDBITS(here.bits);
                     DROPBITS(here.bits);
                     state->lens[state->have++] = here.val;
                 }
diff --git a/inflate.c b/inflate.c
index 214bf26bc..6b0ebbfbc 100644
--- a/inflate.c
+++ b/inflate.c
@@ -944,7 +944,6 @@ int flush;
                     PULLBYTE();
                 }
                 if (here.val < 16) {
-                    NEEDBITS(here.bits);
                     DROPBITS(here.bits);
                     state->lens[state->have++] = here.val;
                 }