From: Mukund Sivaraman <muks@isc.org>
Date: Mon, 19 Mar 2018 12:40:41 +0000 (+0530)
Subject: Check return value of isc_mem_get()
X-Git-Tag: v9.13.0~81^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de3a4af1bf3180beb8a464c0c68ba69c980e51b4;p=thirdparty%2Fbind9.git

Check return value of isc_mem_get()
---

diff --git a/lib/dns/tests/rbt_test.c b/lib/dns/tests/rbt_test.c
index 271952aa42b..aa4c9a6708e 100644
--- a/lib/dns/tests/rbt_test.c
+++ b/lib/dns/tests/rbt_test.c
@@ -162,11 +162,13 @@ test_context_setup(void) {
 		name = dns_fixedname_name(&fname);
 
 		n = isc_mem_get(mctx, sizeof(size_t));
+		ATF_REQUIRE(n != NULL);
 		*n = i + 1;
 		result = dns_rbt_addname(ctx->rbt, name, n);
 		ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
 
 		n = isc_mem_get(mctx, sizeof(size_t));
+		ATF_REQUIRE(n != NULL);
 		*n = node_distances[i];
 		result = dns_rbt_addname(ctx->rbt_distances, name, n);
 		ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
@@ -359,6 +361,7 @@ ATF_TC_BODY(rbt_check_distance_random, tc) {
 		char namebuf[34];
 
 		n = isc_mem_get(mctx, sizeof(size_t));
+		ATF_REQUIRE(n != NULL);
 		*n = i + 1;
 
 		while (1) {
@@ -445,6 +448,7 @@ ATF_TC_BODY(rbt_check_distance_ordered, tc) {
 		dns_name_t *name;
 
 		n = isc_mem_get(mctx, sizeof(size_t));
+		ATF_REQUIRE(n != NULL);
 		*n = i + 1;
 
 		snprintf(namebuf, sizeof(namebuf), "name%08x.", i);
@@ -731,6 +735,7 @@ ATF_TC_BODY(rbt_remove, tc) {
 			ATF_REQUIRE_EQ(node->data, NULL);
 
 			n = isc_mem_get(mctx, sizeof(size_t));
+			ATF_REQUIRE(n != NULL);
 			*n = i;
 
 			node->data = n;
@@ -1139,6 +1144,7 @@ ATF_TC_BODY(rbt_addname, tc) {
 	ctx = test_context_setup();
 
 	n = isc_mem_get(mctx, sizeof(size_t));
+	ATF_REQUIRE(n != NULL);
 	*n = 1;
 
 	dns_test_namefromstring("d.e.f.g.h.i.j.k", &fname);
@@ -1150,6 +1156,7 @@ ATF_TC_BODY(rbt_addname, tc) {
 
 	/* Now add again, should get ISC_R_EXISTS */
 	n = isc_mem_get(mctx, sizeof(size_t));
+	ATF_REQUIRE(n != NULL);
 	*n = 2;
 	result = dns_rbt_addname(ctx->rbt, name, n);
 	ATF_REQUIRE_EQ(result, ISC_R_EXISTS);