From: Jim Meyering <meyering@redhat.com>
Date: Tue, 15 Dec 2009 18:22:31 +0000 (+0100)
Subject: esx_vi.c: do not call through NULL function pointer
X-Git-Tag: v0.7.5~64
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de3e38a65e210195d3e4bf6c5e0efbbfbd4203f6;p=thirdparty%2Flibvirt.git

esx_vi.c: do not call through NULL function pointer

* src/esx/esx_vi.c (esxVI_List_CastFromAnyType): For invalid
inputs, fail right away.  Do not "goto failure" where a NULL
input pointer would be dereferenced.
---

diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index 5725b2fa61..1138e8c14b 100644
--- a/src/esx/esx_vi.c
+++ b/src/esx/esx_vi.c
@@ -935,7 +935,7 @@ esxVI_List_CastFromAnyType(virConnectPtr conn, esxVI_AnyType *anyType,
     if (list == NULL || *list != NULL ||
         castFromAnyTypeFunc == NULL || freeFunc == NULL) {
         ESX_VI_ERROR(conn, VIR_ERR_INTERNAL_ERROR, "Invalid argument");
-        goto failure;
+        return -1;
     }
 
     if (anyType == NULL) {
@@ -946,7 +946,7 @@ esxVI_List_CastFromAnyType(virConnectPtr conn, esxVI_AnyType *anyType,
         ESX_VI_ERROR(conn, VIR_ERR_INTERNAL_ERROR,
                      "Expecting type to begin with 'ArrayOf' but found '%s'",
                      anyType->other);
-        goto failure;
+        return -1;
     }
 
     for (childNode = anyType->_node->xmlChildrenNode; childNode != NULL;