From: Dave Hart <hart@ntp.org>
Date: Tue, 28 Apr 2009 17:43:39 +0000 (+0000)
Subject: Merge shiny.ad.hartbrothers.com:C:/ntp/ntp-dev-1169
X-Git-Tag: NTP_4_2_5P168~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de721b95b62e32b090c7a9afa66a51fe4844b21c;p=thirdparty%2Fntp.git

Merge shiny.ad.hartbrothers.com:C:/ntp/ntp-dev-1169
into  shiny.ad.hartbrothers.com:C:/ntp/ntp-dev-1166-7-9

bk: 49f7404bBNo8LdDsuC1ir8bSFeqA1w
---

de721b95b62e32b090c7a9afa66a51fe4844b21c
diff --cc ChangeLog
index 711086f87,e4d7b5a04..fa4505f72
--- a/ChangeLog
+++ b/ChangeLog
@@@ -1,5 -1,7 +1,9 @@@
+ * [Bug 1169] quiet compiler warnings
+ * Re-enable gcc -Wstrict-prototypes when not building with OpenSSL
+ * Enable gcc -Wstrict-overflow
+ * ntpq/ntpdc emit newline after accepting password on Windows
 +* m4/ntp_lineeditlibs.m4: fix warnings from newer Autoconf
 +* Remove truncation of position (blanking) code in refclock_nmea.c
  (4.2.5p167) 2009/04/26 Released by Harlan Stenn <stenn@ntp.org>
  * Crypto cleanup from Dave Mills.
  (4.2.5p166) 2009/04/25 Released by Harlan Stenn <stenn@ntp.org>
diff --cc configure.ac
index 80b9e32f3,373742b10..20b33a7db
--- a/configure.ac
+++ b/configure.ac
@@@ -284,27 -255,14 +284,17 @@@ case "$GCC" i
      CFLAGS="$CFLAGS -Wmissing-prototypes"
      CFLAGS="$CFLAGS -Wpointer-arith"
      CFLAGS="$CFLAGS -Wshadow"
-     #
-     # OpenSSL has a number of callback prototypes
-     # inside other function prototypes which trigger
-     # warnings with -Wstrict-prototypes, such as:
-     #
-     # int i2d_RSA_NET(const RSA *a, unsigned char **pp, 
-     #                 int (*cb)(), int sgckey);
-     #                 ^^^^^^^^^^^
-     #
-     CFLAGS="$CFLAGS -Wno-strict-prototypes"
      # CFLAGS="$CFLAGS -Wtraditional"
      # CFLAGS="$CFLAGS -Wwrite-strings"
 -    CFLAGS="$CFLAGS -Winit-self"
 +    case "$ac_cv_gcc_Winit_self" in
 +     yes)
 +	CFLAGS="$CFLAGS -Winit-self"
 +    esac
      case "$ac_cv_gcc_Wstrict_overflow" in
       yes)
- 	#not yet: CFLAGS="$CFLAGS -Wstrict-overflow"
+ 	CFLAGS="$CFLAGS -Wstrict-overflow"
      esac
-     ;;
+     # if building with OpenSSL, -Wno-strict-prototypes is added later
  esac
  
  case "$host" in