From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Fri, 28 May 2021 08:25:07 +0000 (+0200)
Subject: BUG/MINOR: quic: Do not check the acception of a new conn from I/O handler.
X-Git-Tag: v2.5-dev8~136
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de935f34e5aa0d3c8e12aa56308623a63ed806e8;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: Do not check the acception of a new conn from I/O handler.

As the ->conn member of quic_conn struct is reset to NULL value by the ->accept
callback potentially run by another thread, this check is irrelevant.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 633767a1a2..6e2fde9b58 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -3267,11 +3267,6 @@ static ssize_t qc_lstnr_pkt_rcv(unsigned char **buf, const unsigned char *end,
 			LIST_APPEND(&l->rx.qpkts, &pkt->rx_list);
 			/* Try to accept a new connection. */
 			listener_accept(l);
-			if (!qc->conn) {
-				TRACE_PROTO("Non accepted connection", QUIC_EV_CONN_LPKT, qc->conn);
-				goto err;
-			}
-
 			if (!quic_conn_init_timer(qc)) {
 				TRACE_PROTO("Non initialized timer", QUIC_EV_CONN_LPKT, qc->conn);
 				goto err;