From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Sun, 16 Mar 2025 08:18:24 +0000 (+0400)
Subject: qemu-slirp: drop unneeded check for OOM
X-Git-Tag: v11.2.0-rc1~119
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de9b1f0e7277b6655bc730e874964b6e8ba3b79e;p=thirdparty%2Flibvirt.git

qemu-slirp: drop unneeded check for OOM

glib anti-pattern, since it aborts on OOM.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/qemu/qemu_slirp.c b/src/qemu/qemu_slirp.c
index 66d9d77c6c..eac7e4cc47 100644
--- a/src/qemu/qemu_slirp.c
+++ b/src/qemu/qemu_slirp.c
@@ -99,12 +99,6 @@ qemuSlirpNewForHelper(const char *helper)
     size_t i, nfeatures;
 
     slirp = qemuSlirpNew();
-    if (!slirp) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Failed to allocate slirp for '%1$s'"), helper);
-        return NULL;
-    }
-
     cmd = virCommandNewArgList(helper, "--print-capabilities", NULL);
     virCommandSetOutputBuffer(cmd, &output);
     if (virCommandRun(cmd, NULL) < 0)