From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 2 Apr 2013 15:18:30 +0000 (+0200)
Subject: virsh: Call virDomainFree in cmdDomFSTrim
X-Git-Tag: v1.0.5-rc1~272
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=deb86ee9123ef47dce80dd77a9bc583f2b0214db;p=thirdparty%2Flibvirt.git

virsh: Call virDomainFree in cmdDomFSTrim

https://bugzilla.redhat.com/show_bug.cgi?id=928197

The virsh domfstrim command was not freeing allocated domain,
leaving leaked references behind.
---

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 5ddcedc89f..92796601a2 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10040,7 +10040,7 @@ cmdDomFSTrim(vshControl *ctl, const vshCmd *cmd)
     unsigned int flags = 0;
 
     if (!(dom = vshCommandOptDomain(ctl, cmd, NULL)))
-        goto cleanup;
+        return ret;
 
     if (vshCommandOptULongLong(cmd, "minimum", &minimum) < 0) {
         vshError(ctl, _("Unable to parse integer parameter minimum"));
@@ -10058,6 +10058,7 @@ cmdDomFSTrim(vshControl *ctl, const vshCmd *cmd)
     ret = true;
 
 cleanup:
+    virDomainFree(dom);
     return ret;
 }