From: NeilBrown <neilb@suse.de>
Date: Tue, 10 May 2011 06:30:40 +0000 (+1000)
Subject: Give suitable error for mdadm /dev/md0 --stop
X-Git-Tag: mdadm-3.2.2~77
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dec18cae724516353ef911f5bed6c3bfee5845f1;p=thirdparty%2Fmdadm.git

Give suitable error for mdadm /dev/md0 --stop

Options like --stop must come before the device that is being
stopped.  If (in --misc mode) a  device does not have an option,
nothing will be done to it, which can be confusing.
So report an error in this case.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/mdadm.c b/mdadm.c
index 96d32b53..662822d1 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -253,6 +253,12 @@ int main(int argc, char *argv[])
 			exit(2);
 		} else if (!mode && newmode) {
 			mode = newmode;
+			if (mode == MISC && devs_found) {
+				fprintf(stderr, Name ": No action given for %s in --misc mode\n",
+					devlist->devname);
+				fprintf(stderr,"       Action options must come before device names\n");
+				exit(2);
+			}
 		} else {
 			/* special case of -c --help */
 			if ((opt == 'c' || opt == ConfigFile) &&