From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Wed, 14 Apr 2021 16:28:20 +0000 (+0200)
Subject: comments from code review
X-Git-Tag: rec-4.4.4~7^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dedf095ef92c831fc89f916d828671e8b3f2d093;p=thirdparty%2Fpdns.git

comments from code review

(cherry picked from commit 34b0536b713515b4cc89d8a28ea27822ef0880dc)
---

diff --git a/pdns/filterpo.cc b/pdns/filterpo.cc
index ff3f6bdff9..8a869b778c 100644
--- a/pdns/filterpo.cc
+++ b/pdns/filterpo.cc
@@ -715,8 +715,7 @@ DNSName DNSFilterEngine::Zone::maskToRPZ(const Netmask& nm)
     struct { int base, len; } best = {-1, 0}, cur = {-1, 0};
 
     for (int i = 0; i < (int)elems.size(); i++) {
-      auto elem = ntohs(src[i]);
-      elems[i] = elem;
+      elems[i] = ntohs(src[i]);
       if (elems[i] == 0) {
         if (cur.base == -1) {  // start of a run of zeroes
           cur = { i, 1 };
@@ -743,7 +742,7 @@ DNSName DNSFilterEngine::Zone::maskToRPZ(const Netmask& nm)
       best.base = -1;
     }
     for (int i=0; i < (int)elems.size(); i++) {
-      if (i==best.base) {
+      if (i == best.base) {
         temp = DNSName("zz") + temp;
         i = i + best.len - 1;
       } else {