From: noopbug <noopbug@users.noreply.github.com>
Date: Wed, 1 Nov 2023 21:20:29 +0000 (-0500)
Subject: When scanning interfaces with WMI, include networks without a domain. (#999)
X-Git-Tag: v2.5.0rc1~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=defa13edf76ccd34591c0b38cfde3b63973c2d4a;p=thirdparty%2Fdnspython.git

When scanning interfaces with WMI, include networks without a domain. (#999)

* When scanning interfaces with WMI, include networks without a domain.

* Ignore networks found via wmi that have no nameservers

---------

Co-authored-by: Me <me@shiranpuri.com>
---

diff --git a/dns/win32util.py b/dns/win32util.py
index b2ca61da..3e67c6bb 100644
--- a/dns/win32util.py
+++ b/dns/win32util.py
@@ -51,9 +51,10 @@ if sys.platform == "win32":
                 try:
                     system = wmi.WMI()
                     for interface in system.Win32_NetworkAdapterConfiguration():
-                        if interface.IPEnabled and interface.DNSDomain:
-                            self.info.domain = _config_domain(interface.DNSDomain)
+                        if interface.IPEnabled and interface.DNSServerSearchOrder:
                             self.info.nameservers = list(interface.DNSServerSearchOrder)
+                            if interface.DNSDomain:
+                                self.info.domain = _config_domain(interface.DNSDomain)
                             if interface.DNSDomainSuffixSearchOrder:
                                 self.info.search = [
                                     _config_domain(x)