From: Jan Safranek <jsafrane@redhat.com>
Date: Wed, 24 Aug 2011 09:40:05 +0000 (+0200)
Subject: libcgroup: Fixed potential crash when setting a parameter value
X-Git-Tag: v0.38~61
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=df3431f4447c77abff47fd1799a5d13c792e07f1;p=thirdparty%2Flibcgroup.git

libcgroup: Fixed potential crash when setting a parameter value

fclose(NULL) dereferences its argument -> sigsegv.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
---

diff --git a/src/api.c b/src/api.c
index e443ad50..71cec93d 100644
--- a/src/api.c
+++ b/src/api.c
@@ -1313,9 +1313,9 @@ static int cg_set_control_value(char *path, const char *val)
 					free(tasks_path);
 					return ECGROUPSUBSYSNOTMOUNTED;
 				}
+			} else {
+				fclose(control_file);
 			}
-
-			fclose(control_file);
 			free(tasks_path);
 			return ECGROUPNOTALLOWED;
 		}