From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 16 Nov 2020 12:58:08 +0000 (+0200)
Subject: lib: module_dir_*load*(): Avoid growing data stack when checking duplicates
X-Git-Tag: 2.3.16~246
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=df4f7032cb3f32f548806972c962b71e7010653d;p=thirdparty%2Fdovecot%2Fcore.git

lib: module_dir_*load*(): Avoid growing data stack when checking duplicates

This check could have unnecessarily grown data stack size when many plugins
are installed.
---

diff --git a/src/lib/module-dir.c b/src/lib/module-dir.c
index 5de0dedfab..5576df3cb4 100644
--- a/src/lib/module-dir.c
+++ b/src/lib/module-dir.c
@@ -314,13 +314,13 @@ static void check_duplicates(ARRAY_TYPE(const_string) *names,
 
 	base_name = module_file_get_name(name);
 	names_p = array_get(names, &count);
-	for (i = 0; i < count; i++) {
+	for (i = 0; i < count; i++) T_BEGIN {
 		tmp = module_file_get_name(names_p[i]);
 
 		if (strcmp(tmp, base_name) == 0)
 			i_fatal("Multiple files for module %s: %s/%s, %s/%s",
 				base_name, dir, name, dir, names_p[i]);
-	}
+	} T_END;
 }
 
 struct module *module_dir_find(struct module *modules, const char *name)