From: David Vašek <david.vasek@nic.cz>
Date: Mon, 31 Oct 2022 15:01:41 +0000 (+0100)
Subject: refresh: if refresh fails, log the time of the next retry attempt
X-Git-Tag: v3.4.dev~323^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=df56613f58bb6ebdebe8db89951236b2fd3d5f1a;p=thirdparty%2Fknot-dns.git

refresh: if refresh fails, log the time of the next retry attempt
---

diff --git a/src/knot/events/handlers/refresh.c b/src/knot/events/handlers/refresh.c
index 7754491e88..c5d9982b82 100644
--- a/src/knot/events/handlers/refresh.c
+++ b/src/knot/events/handlers/refresh.c
@@ -1358,8 +1358,6 @@ int event_refresh(conf_t *conf, zone_t *zone)
 	int ret = zone_master_try(conf, zone, try_refresh, &trctx, "refresh");
 	zone_clear_preferred_master(zone);
 	if (ret != KNOT_EOK) {
-		log_zone_error(zone->name, "refresh, failed (%s)", knot_strerror(ret));
-
 		const knot_rdataset_t *soa = zone_soa(zone);
 		uint32_t next;
 
@@ -1373,6 +1371,14 @@ int event_refresh(conf_t *conf, zone_t *zone)
 		            C_RETRY_MIN_INTERVAL, C_RETRY_MAX_INTERVAL);
 		zone->timers.next_refresh = time(NULL) + next;
 		zone->timers.last_refresh_ok = false;
+
+		char time_str[64] = { 0 };
+		struct tm time_gm = { 0 };
+		localtime_r(&zone->timers.next_refresh, &time_gm);
+		strftime(time_str, sizeof(time_str), KNOT_LOG_TIME_FORMAT, &time_gm);
+
+		log_zone_error(zone->name, "refresh, failed (%s), next retry at %s",
+		               knot_strerror(ret), time_str);
 	}
 
 	/* Reschedule events. */