From: Selva Nair Date: Thu, 20 Feb 2020 01:56:43 +0000 (-0500) Subject: Fix possible access of uninitialized pipe handles X-Git-Tag: v2.4.9~5 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=df5ea7f1b87012414d2625d1562715887ad1686d;p=thirdparty%2Fopenvpn.git Fix possible access of uninitialized pipe handles Compile time warning for openvpnserv.exe interactive.c: In function ‘RunOpenvpn’: interactive.c:160:27: warning: ‘svc_pipe’ may be used uninitialized in this function [-Wmaybe-uninitialized] When RunOpenvpn exits early due to errors, uninitialized svc_pipe and ovpn_pipe vars could get passed to CloseHandleEx(). Fix by initializing to NULL. Signed-off-by: Selva Nair Acked-by: Lev Stipakov Message-Id: <1582163803-3342-1-git-send-email-selva.nair@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19480.html Signed-off-by: David Sommerseth (cherry picked from commit 32723d29b2775d63d3fe329d017e7a08e0cdcb72) --- diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index a2b3b2019..aecbd842a 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1349,7 +1349,7 @@ static DWORD WINAPI RunOpenvpn(LPVOID p) { HANDLE pipe = p; - HANDLE ovpn_pipe, svc_pipe; + HANDLE ovpn_pipe = NULL, svc_pipe = NULL; PTOKEN_USER svc_user = NULL, ovpn_user = NULL; HANDLE svc_token = NULL, imp_token = NULL, pri_token = NULL; HANDLE stdin_read = NULL, stdin_write = NULL;