From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 27 Aug 2021 19:42:28 +0000 (-0400)
Subject: more descriptive error messages
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=df8f7819714dd31eaf31446129f58e5b08a239ea;p=thirdparty%2Ffreeradius-server.git

more descriptive error messages
---

diff --git a/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c b/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c
index 7e2644de5dd..f9eb50c93ac 100644
--- a/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c
+++ b/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c
@@ -163,7 +163,8 @@ static ssize_t eap_ttls_decode_pair(TALLOC_CTX *ctx, fr_dcursor_t *cursor, fr_di
 		fr_dict_attr_t const	*our_parent = parent;
 
 		if ((end - p) < 8) {
-			fr_strerror_printf("Malformed diameter VPs.  Needed at least 8 bytes, got %zu bytes", end - p);
+			fr_strerror_printf("Malformed diameter attribute at offset %zu.  Needed at least 8 bytes, got %zu bytes",
+					   p - data, end - p);
 		error:
 			fr_dcursor_free_list(cursor);
 			return -1;
@@ -179,14 +180,14 @@ static ssize_t eap_ttls_decode_pair(TALLOC_CTX *ctx, fr_dcursor_t *cursor, fr_di
 		p += 3;
 
 		if (value_len < 8) {
-			fr_strerror_printf("Malformed diameter VPs.  Needed at least length of 8, got %u",
-					   (unsigned int) value_len);
+			fr_strerror_printf("Malformed diameter attribute at offset %zu.  Needed at least length of 8, got %u",
+					   p - data, (unsigned int) value_len);
 			goto error;
 		}
 
 		if ((p + ((value_len + 0x03) & ~0x03)) > end) {
-			fr_strerror_printf("Malformed diameter VPs.  Value length %u overflows input",
-					   (unsigned int) value_len);
+			fr_strerror_printf("Malformed diameter attribute at offset %zu.  Value length %u overflows input",
+					   p - data, (unsigned int) value_len);
 			goto error;
 		}