From: Štěpán Němec <stepnem@smrk.net>
Date: Mon, 28 Aug 2023 10:42:44 +0000 (+0200)
Subject: spawn: remove stray variable $ndc_err
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dfa49359f0cc8a13798904c2346dab4607cd9e68;p=thirdparty%2Fpublic-inbox.git

spawn: remove stray variable $ndc_err

Code that could be setting it was removed in 14fa0abdcc7b.
Likewise for the double assignment to $err.

Fixes: 14fa0abdcc7b ("rewrite Linux nodatacow use in pure Perl w/o system")
---

diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 878843a60..6e33c712d 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -293,15 +293,12 @@ ALL_LIBC
 use Inline C => $all_libc, BUILD_NOISY => 1;
 EOM
 		my $err = $@;
-		my $ndc_err = '';
-		$err = $@;
 		open(STDERR, '>&', $olderr) or warn "restore stderr: $!";
 		open(STDOUT, '>&', $oldout) or warn "restore stdout: $!";
 		if ($err) {
 			seek($fh, 0, SEEK_SET);
 			my @msg = <$fh>;
-			warn "Inline::C build failed:\n",
-				$ndc_err, $err, "\n", @msg;
+			warn "Inline::C build failed:\n", $err, "\n", @msg;
 			$all_libc = undef;
 		}
 	}