From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Wed, 25 Jan 2012 17:49:58 +0000 (-0500)
Subject: - [bug] Added ORA-03135 to the never ending
X-Git-Tag: rel_0_7_5~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dfb0b6aa622006e1e71a5296c3fa17667e24aac1;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- [bug] Added ORA-03135 to the never ending
list of oracle "connection lost" errors
[ticket:2388]
---

diff --git a/CHANGES b/CHANGES
index b09790e64d..ba73273997 100644
--- a/CHANGES
+++ b/CHANGES
@@ -99,6 +99,11 @@ CHANGES
     is on this driver and how SQLAlchemy's
     implementation should adapt.  [ticket:2347]
 
+- oracle
+  - [bug] Added ORA-03135 to the never ending
+    list of oracle "connection lost" errors
+    [ticket:2388]
+
 - Py3K
   - [bug] Fixed inappropriate usage of util.py3k
     flag and renamed it to util.py3k_warning, since 
diff --git a/lib/sqlalchemy/dialects/oracle/cx_oracle.py b/lib/sqlalchemy/dialects/oracle/cx_oracle.py
index a7ce209f49..64526d213e 100644
--- a/lib/sqlalchemy/dialects/oracle/cx_oracle.py
+++ b/lib/sqlalchemy/dialects/oracle/cx_oracle.py
@@ -695,8 +695,10 @@ class OracleDialect_cx_oracle(OracleDialect):
             # ORA-00028: your session has been killed
             # ORA-03114: not connected to ORACLE
             # ORA-03113: end-of-file on communication channel
+            # ORA-03135: connection lost contact
             # ORA-01033: ORACLE initialization or shutdown in progress
-            return error.code in (28, 3114, 3113, 1033)
+            # TODO: Others ?
+            return error.code in (28, 3114, 3113, 3135, 1033)
         else:
             return False