From: Marcin Siodelski <marcin@isc.org>
Date: Wed, 26 Sep 2012 14:45:19 +0000 (+0200)
Subject: [2187] Changes suggested in code review.
X-Git-Tag: trac2351_base~37^2~3^2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dfc79b64ed8fdf77c46ebea1e025e229b7497a60;p=thirdparty%2Fkea.git

[2187] Changes suggested in code review.
---

diff --git a/src/lib/dhcp/tests/iface_mgr_unittest.cc b/src/lib/dhcp/tests/iface_mgr_unittest.cc
index 9ca789970f..2c7b86b182 100644
--- a/src/lib/dhcp/tests/iface_mgr_unittest.cc
+++ b/src/lib/dhcp/tests/iface_mgr_unittest.cc
@@ -439,6 +439,8 @@ TEST_F(IfaceMgrTest, sockets6) {
     // removed code for binding socket twice to the same address/port
     // as it caused problems on some platforms (e.g. Mac OS X)
 
+    // Close sockets here because the following tests will want to
+    // open sockets on the same ports.
     ifacemgr->closeSockets();
 
     // Use address that is not assigned to LOOPBACK iface.
@@ -453,6 +455,9 @@ TEST_F(IfaceMgrTest, sockets6) {
         ifacemgr->openSocket("non_existing_interface", loAddr, 10548),
         BadValue
     );
+
+    // Do not call closeSockets() because it is called by IfaceMgr's
+    // virtual destructor.
 }
 
 TEST_F(IfaceMgrTest, socketsFromIface) {
@@ -476,6 +481,8 @@ TEST_F(IfaceMgrTest, socketsFromIface) {
     EXPECT_GT(socket2, 0);
     close(socket2);
 
+    // Close sockets here because the following tests will want to
+    // open sockets on the same ports.
     ifacemgr->closeSockets();
 
     // Use invalid interface name.
@@ -483,6 +490,9 @@ TEST_F(IfaceMgrTest, socketsFromIface) {
         ifacemgr->openSocketFromIface("non_existing_interface", PORT1, AF_INET),
         BadValue
     );
+
+    // Do not call closeSockets() because it is called by IfaceMgr's
+    // virtual destructor.
 }
 
 
@@ -507,6 +517,8 @@ TEST_F(IfaceMgrTest, socketsFromAddress) {
     // socket descriptor must be positive integer
     EXPECT_GT(socket2, 0);
 
+    // Close sockets here because the following tests will want to
+    // open sockets on the same ports.
     ifacemgr->closeSockets();
 
     // Use non-existing address.
@@ -514,6 +526,9 @@ TEST_F(IfaceMgrTest, socketsFromAddress) {
     EXPECT_THROW(
         ifacemgr->openSocketFromAddress(invalidAddr, PORT1), BadValue
     );
+
+    // Do not call closeSockets() because it is called by IfaceMgr's
+    // virtual destructor.
 }
 
 TEST_F(IfaceMgrTest, socketsFromRemoteAddress) {
@@ -537,6 +552,8 @@ TEST_F(IfaceMgrTest, socketsFromRemoteAddress) {
     );
     EXPECT_GT(socket2, 0);
 
+    // Close sockets here because the following tests will want to
+    // open sockets on the same ports.
     ifacemgr->closeSockets();
 
     // The following test is currently disabled for OSes other than
@@ -552,6 +569,9 @@ TEST_F(IfaceMgrTest, socketsFromRemoteAddress) {
     );
     EXPECT_GT(socket3, 0);
 #endif
+
+    // Do not call closeSockets() because it is called by IfaceMgr's
+    // virtual destructor.
 }
 
 // TODO: disabled due to other naming on various systems
diff --git a/tests/tools/perfdhcp/test_control.cc b/tests/tools/perfdhcp/test_control.cc
index 55a3c3c464..7ab4f01a88 100644
--- a/tests/tools/perfdhcp/test_control.cc
+++ b/tests/tools/perfdhcp/test_control.cc
@@ -788,7 +788,7 @@ TestControl::receivePackets(const TestControlSocket& socket) {
             try {
                 pkt4 = IfaceMgr::instance().receive4(timeout);
             } catch (const Exception& e) {
-                std::cout << "Failed to receive DHCPv4 packet: "
+                std::cerr << "Failed to receive DHCPv4 packet: "
                           << e.what() <<  std::endl;
             }
             if (!pkt4) {
@@ -806,7 +806,7 @@ TestControl::receivePackets(const TestControlSocket& socket) {
             try {
                 pkt6 = IfaceMgr::instance().receive6(timeout);
             } catch (const Exception& e) {
-                std::cout << "Failed to receive DHCPv6 packet: "
+                std::cerr << "Failed to receive DHCPv6 packet: "
                           << e.what() << std::endl;
             }
             if (!pkt6) {