From: Michał Kępień <michal@isc.org>
Date: Tue, 18 Mar 2025 05:19:01 +0000 (+0100)
Subject: Broaden vulture exclude glob for ans.py servers
X-Git-Tag: v9.21.7~47^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dfd37918d6913b783ead915d608b5951386f5974;p=thirdparty%2Fbind9.git

Broaden vulture exclude glob for ans.py servers

The vulture tool seems to be unable to follow how the parent classes
defined in bin/tests/system/qmin/qmin_ans.py use mandatory properties
specified by child classes in bin/tests/system/qmin/ans*/ans.py.  Make
the tool ignore not just ans.py servers, but also *_ans.py utility
modules above the ansX/ subdirectories to prevent false positives about
unused code from causing CI pipeline failures.
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9cf947e5fc3..5544a0ac7ca 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -584,7 +584,7 @@ vulture:
   <<: *precheck_job
   needs: []
   script:
-    - vulture --exclude "*/ans*/ans.py,conftest.py,isctest" --ignore-names "pytestmark" bin/tests/system/
+    - vulture --exclude "*ans.py,conftest.py,isctest" --ignore-names "pytestmark" bin/tests/system/
 
 ci-variables:
   stage: precheck