From: Jorge Pereira <jpereira@freeradius.org>
Date: Fri, 30 Jun 2023 18:52:54 +0000 (-0300)
Subject: Fix issue with memory usage after being released.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dfd71b9085ec4dd5c89b8930f8ea1a9a951730bb;p=thirdparty%2Ffreeradius-server.git

Fix issue with memory usage after being released.
---

diff --git a/src/modules/rlm_sqlcounter/rlm_sqlcounter.c b/src/modules/rlm_sqlcounter/rlm_sqlcounter.c
index 33d6d053f54..1a3849e49b9 100644
--- a/src/modules/rlm_sqlcounter/rlm_sqlcounter.c
+++ b/src/modules/rlm_sqlcounter/rlm_sqlcounter.c
@@ -424,7 +424,6 @@ static unlang_action_t CC_HINT(nonnull) mod_authorize(rlm_rcode_t *p_result, mod
 	if (xlat_aeval(request, &expanded, request, query, NULL, NULL) < 0) {
 		RETURN_MODULE_FAIL;
 	}
-	talloc_free(expanded);
 
 	if (sscanf(expanded, "%" PRIu64, &counter) != 1) {
 		RDEBUG2("No integer found in result string \"%s\".  May be first session, setting counter to 0",
@@ -432,6 +431,8 @@ static unlang_action_t CC_HINT(nonnull) mod_authorize(rlm_rcode_t *p_result, mod
 		counter = 0;
 	}
 
+	talloc_free(expanded);
+
 	/*
 	 *	Check if check item > counter
 	 */