From: Joshua Morris <joshuajohnmorris@gmail.com>
Date: Sun, 4 Jun 2023 09:15:28 +0000 (+1000)
Subject: Remove `sep` argument from `string_agg`
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dfd88ef1d9ec484616e226e1a2de8dec925a4204;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Remove `sep` argument from `string_agg`

As it is always the last argument, and document this
---

diff --git a/lib/sqlalchemy/sql/functions.py b/lib/sqlalchemy/sql/functions.py
index 5978ec5ade..1ca0a0468c 100644
--- a/lib/sqlalchemy/sql/functions.py
+++ b/lib/sqlalchemy/sql/functions.py
@@ -1807,12 +1807,13 @@ class string_agg(GenericFunction[_T]):
     This function will concatenate non-null values into a string and
     separate the values by a delimeter.
 
+    e.g. Example usage with delimeter '.' as the last argument
+
+    stmt = select(func.string_agg(table.c.str_col, "."))
+
     The return type of this function is :class:`.String`.
 
     """
     type = sqltypes.String()
     _has_args = True
     inherit_cache = True
-
-    def __init__(self, sep=",", *args, **kwargs):
-        super().__init__(sep, *args, **kwargs)