From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 1 Jul 2016 14:38:31 +0000 (+0200)
Subject: conf: Annotate that private data for objects are not copied
X-Git-Tag: v2.1.0-rc1~216
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dfe0f4230169c24f59074c3b30d8eb450463fb5f;p=thirdparty%2Flibvirt.git

conf: Annotate that private data for objects are not copied

Our copy functions format and parse XML thus are not able to copy data.
Annotate the private data pointers that this is happening.
---

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a1acebe9d4..eb3a5f30f8 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2404,6 +2404,8 @@ typedef virDomainXMLPrivateDataCallbacks *virDomainXMLPrivateDataCallbacksPtr;
 struct _virDomainXMLPrivateDataCallbacks {
     virDomainXMLPrivateDataAllocFunc  alloc;
     virDomainXMLPrivateDataFreeFunc   free;
+    /* note that private data for devices are not copied when using
+     * virDomainDefCopy and similar functions */
     virDomainXMLPrivateDataNewFunc    diskNew;
     virDomainXMLPrivateDataNewFunc    hostdevNew;
     virDomainXMLPrivateDataFormatFunc format;