From: markus@openbsd.org <markus@openbsd.org>
Date: Wed, 13 Nov 2019 20:25:45 +0000 (+0000)
Subject: upstream: fix check for sig_s; noted by qsa at qualys.com
X-Git-Tag: V_8_2_P1~318
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dffd02e297e6c2a4e86775f293eb1b0ff01fb3df;p=thirdparty%2Fopenssh-portable.git

upstream: fix check for sig_s; noted by qsa at qualys.com

OpenBSD-Commit-ID: 34198084e4afb424a859f52c04bb2c9668a52867
---

diff --git a/ssh-sk.c b/ssh-sk.c
index 41fa164b7..754577d9d 100644
--- a/ssh-sk.c
+++ b/ssh-sk.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-sk.c,v 1.10 2019/11/12 22:38:19 djm Exp $ */
+/* $OpenBSD: ssh-sk.c,v 1.11 2019/11/13 20:25:45 markus Exp $ */
 /*
  * Copyright (c) 2019 Google LLC
  *
@@ -366,7 +366,7 @@ sshsk_ecdsa_sig(struct sk_sign_response *resp, struct sshbuf *sig)
 	int r = SSH_ERR_INTERNAL_ERROR;
 
 	/* Check response validity */
-	if (resp->sig_r == NULL || resp->sig_r == NULL) {
+	if (resp->sig_r == NULL || resp->sig_s == NULL) {
 		error("%s: sk_sign response invalid", __func__);
 		r = SSH_ERR_INVALID_FORMAT;
 		goto out;