From: SeongJae Park Date: Sat, 5 Jul 2025 17:49:59 +0000 (-0700) Subject: mm/damon/sysfs: don't hold kdamond_lock in before_terminate() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e000df9ff183e7adc938db8a739690de112dd961;p=thirdparty%2Flinux.git mm/damon/sysfs: don't hold kdamond_lock in before_terminate() damon_sysfs_before_terminate() is a DAMON callback that is executed from the kdamond's context. Hence it is safe to access DAMON context internal data. But the function is unnecessarily holding kdamond_lock of the context. It is just unnecessary. Remove the locking code. Link: https://lkml.kernel.org/r/20250705175000.56259-6-sj@kernel.org Signed-off-by: SeongJae Park Signed-off-by: Andrew Morton --- diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 79d65dcc9dd03..c0193de6fb9af 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1387,12 +1387,10 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) if (!damon_target_has_pid(ctx)) return; - mutex_lock(&ctx->kdamond_lock); damon_for_each_target_safe(t, next, ctx) { put_pid(t->pid); damon_destroy_target(t); } - mutex_unlock(&ctx->kdamond_lock); } /*