From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 10 Aug 2023 02:27:55 +0000 (+1200)
Subject: s4:kdc: Don’t log secret keys
X-Git-Tag: tevent-0.16.0~1011
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e035cfabc713c0a47f273fa61ab199ed0b563d98;p=thirdparty%2Fsamba.git

s4:kdc: Don’t log secret keys

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index 572bf95a966..55885e37247 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -678,7 +678,6 @@ krb5_error_code samba_kdc_message2entry_keys(krb5_context context,
 		ndr_err = ndr_pull_struct_blob_all(sc_val, mem_ctx, &scb,
 						   (ndr_pull_flags_fn_t)ndr_pull_supplementalCredentialsBlob);
 		if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-			dump_data(0, sc_val->data, sc_val->length);
 			ret = EINVAL;
 			goto out;
 		}