From: Håkan Lindqvist <h@qw.se>
Date: Thu, 11 May 2023 14:25:35 +0000 (+0000)
Subject: Clarify log message for NODATA/NXDOMAIN without AA
X-Git-Tag: rec-5.0.0-alpha1~119^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e053d2cece486c06a0fda877094a04ce32abbf68;p=thirdparty%2Fpdns.git

Clarify log message for NODATA/NXDOMAIN without AA

The old log message did not indicate the specific reason why the
record was considered irrelevant, logging only information about
a SOA record that quite likely is both normal and relevant.

This somewhat helps explaining what the actual problem is.
---

diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc
index f7270474f1..3195b4095b 100644
--- a/pdns/recursordist/syncres.cc
+++ b/pdns/recursordist/syncres.cc
@@ -4163,7 +4163,7 @@ void SyncRes::sanitizeRecords(const std::string& prefix, LWResult& lwr, const DN
       }
 
       if (!(lwr.d_aabit || wasForwardRecurse)) {
-        LOG(prefix << qname << ": Removing irrelevant record '" << rec->d_name << "|" << DNSRecordContent::NumberToType(rec->d_type) << "|" << rec->getContent()->getZoneRepresentation() << "' in the AUTHORITY section received from " << auth << endl);
+        LOG(prefix << qname << ": Removing irrelevant record (AA not set) '" << rec->d_name << "|" << DNSRecordContent::NumberToType(rec->d_type) << "|" << rec->getContent()->getZoneRepresentation() << "' in the AUTHORITY section received from " << auth << endl);
         rec = lwr.d_records.erase(rec);
         continue;
       }