From: Henryk Plötz <henryk@ploetzli.ch>
Date: Sat, 1 Dec 2018 23:04:29 +0000 (+0100)
Subject: Fix a FIXME (by turning it into a note)
X-Git-Tag: v2.0.0~1^2~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e05a2f2ab8f28a24e767c69afdfb663095a06542;p=thirdparty%2Fpython-fints.git

Fix a FIXME (by turning it into a note)
---

diff --git a/fints/client.py b/fints/client.py
index 0e0ebc4..a194489 100644
--- a/fints/client.py
+++ b/fints/client.py
@@ -492,7 +492,9 @@ class FinTS3Client:
 
         statement = []
         for seg in responses:
-            # FIXME What is the encoding of MT940 messages?
+            # Note: MT940 messages are encoded in the S.W.I.F.T character set,
+            # which is a subset of ISO 8859. There are no character in it that
+            # differ between ISO 8859 variants, so we'll arbitrarily chose 8859-1.
             statement += mt940_to_array(seg.statement_booked.decode('iso-8859-1'))
 
         logger.debug('Statement: {}'.format(statement))