From: Jennifer Liu <jenniferliu620@fb.com>
Date: Fri, 29 Jun 2018 22:38:08 +0000 (-0700)
Subject: Another fix to comparator
X-Git-Tag: v0.0.29~69^2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e061d840167f6f21f9ad4ea9c9fe3185eeb32a36;p=thirdparty%2Fzstd.git

Another fix to comparator
---

diff --git a/lib/dictBuilder/cover.c b/lib/dictBuilder/cover.c
index dbb90c1f0..4dead220a 100644
--- a/lib/dictBuilder/cover.c
+++ b/lib/dictBuilder/cover.c
@@ -560,7 +560,7 @@ static int COVER_ctx_init(COVER_ctx_t *ctx, const void *samplesBuffer,
     return 0;
   }
   /* Check if there's testing sample when splitPoint is nonzero */
-  if (nbTestSamples < 1 && splitPoint != 1.0) {
+  if (nbTestSamples < 1 && splitPoint < 1.0) {
     DISPLAYLEVEL(1, "Total number of testing samples is %u and is invalid.", nbTestSamples);
     DISPLAYLEVEL(1, "splitPoint is %i", (int)(splitPoint*100));
     DISPLAYLEVEL(1, "nbSamples is %u", nbSamples);
@@ -973,7 +973,7 @@ ZDICTLIB_API size_t ZDICT_optimizeTrainFromBuffer_cover(
   /* constants */
   const unsigned nbThreads = parameters->nbThreads;
   const double splitPoint =
-      parameters->splitPoint == 0.0 ? DEFAULT_SPLITPOINT : parameters->splitPoint;
+      parameters->splitPoint <= 0.0 ? DEFAULT_SPLITPOINT : parameters->splitPoint;
   const unsigned kMinD = parameters->d == 0 ? 6 : parameters->d;
   const unsigned kMaxD = parameters->d == 0 ? 8 : parameters->d;
   const unsigned kMinK = parameters->k == 0 ? 50 : parameters->k;