From: Thierry FOURNIER <thierry.fournier@ozon.io>
Date: Wed, 26 Apr 2017 11:27:05 +0000 (+0200)
Subject: CLEANUP: lua: remove test
X-Git-Tag: v1.8-dev2~59
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e068b60605ad5bdf7ec3bde016b4f681171f5443;p=thirdparty%2Fhaproxy.git

CLEANUP: lua: remove test

The man of "luaL_unref" says "If ref is LUA_NOREF or LUA_REFNIL,
luaL_unref does nothing.", so I remove the check.
---

diff --git a/src/hlua.c b/src/hlua.c
index 6ce18e1ca7..643d3fce0b 100644
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -3309,8 +3309,7 @@ __LJMP static int hlua_applet_tcp_set_priv(lua_State *L)
 	MAY_LJMP(check_args(L, 2, "set_priv"));
 
 	/* Remove previous value. */
-	if (hlua->Mref != -1)
-		luaL_unref(L, LUA_REGISTRYINDEX, hlua->Mref);
+	luaL_unref(L, LUA_REGISTRYINDEX, hlua->Mref);
 
 	/* Get and store new value. */
 	lua_pushvalue(L, 2); /* Copy the element 2 at the top of the stack. */
@@ -3772,8 +3771,7 @@ __LJMP static int hlua_applet_http_set_priv(lua_State *L)
 	MAY_LJMP(check_args(L, 2, "set_priv"));
 
 	/* Remove previous value. */
-	if (hlua->Mref != -1)
-		luaL_unref(L, LUA_REGISTRYINDEX, hlua->Mref);
+	luaL_unref(L, LUA_REGISTRYINDEX, hlua->Mref);
 
 	/* Get and store new value. */
 	lua_pushvalue(L, 2); /* Copy the element 2 at the top of the stack. */
@@ -4859,8 +4857,7 @@ __LJMP static int hlua_set_priv(lua_State *L)
 	hlua = hlua_gethlua(L);
 
 	/* Remove previous value. */
-	if (hlua->Mref != -1)
-		luaL_unref(L, LUA_REGISTRYINDEX, hlua->Mref);
+	luaL_unref(L, LUA_REGISTRYINDEX, hlua->Mref);
 
 	/* Get and store new value. */
 	lua_pushvalue(L, 2); /* Copy the element 2 at the top of the stack. */