From: Eric Blake <eblake@redhat.com>
Date: Thu, 30 Jun 2011 23:08:41 +0000 (-0600)
Subject: libvirtd: avoid memory leak on OOM
X-Git-Tag: v0.9.3~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e07e9a9456df21fb4717353b2c3475d4f6c56a05;p=thirdparty%2Flibvirt.git

libvirtd: avoid memory leak on OOM

Detected by Coverity; only strikes on OOM so not serious.

* daemon/libvirtd.c (daemonPidFilePath): Plug leak.
---

diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 60ee705cef..06d2077bd4 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -310,8 +310,10 @@ daemonPidFilePath(bool privileged,
         if (!(userdir = virGetUserDirectory(geteuid())))
             goto error;
 
-        if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0)
+        if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0) {
+            VIR_FREE(userdir);
             goto no_memory;
+        }
 
         VIR_FREE(userdir);
     }