From: David S. Miller Date: Tue, 21 Jan 2020 11:02:25 +0000 (+0100) Subject: hdlx_x25: Fix backwards compat test. X-Git-Tag: v5.6-rc1~151^2~52 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e09538eac996e11d36027cb546a9ac50d07edeb1;p=thirdparty%2Fkernel%2Flinux.git hdlx_x25: Fix backwards compat test. drivers/net/wan/hdlc_x25.c: In function ‘x25_ioctl’: drivers/net/wan/hdlc_x25.c:256:7: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 256 | if (ifr->ifr_settings.size = 0) { | ^~~ Signed-off-by: David S. Miller --- diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c index 63c9aeed9a348..c84536b03aa84 100644 --- a/drivers/net/wan/hdlc_x25.c +++ b/drivers/net/wan/hdlc_x25.c @@ -253,7 +253,7 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr) return -EBUSY; /* backward compatibility */ - if (ifr->ifr_settings.size = 0) { + if (ifr->ifr_settings.size == 0) { new_settings.dce = 0; new_settings.modulo = 8; new_settings.window = 7;