From: Brian Behlendorf <behlendorf1@llnl.gov>
Date: Sat, 24 Mar 2007 02:55:59 +0000 (-0400)
Subject: [COVERITY] Fix (error case) memory leak in blkid library (parse_dev)
X-Git-Tag: E2FSPROGS-1_40~95
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e0a700d45d4d5f85ddedc2344f336e9bb73a8b29;p=thirdparty%2Fe2fsprogs.git

[COVERITY] Fix (error case) memory leak in blkid library (parse_dev)

Coverity ID: 29: Resource Leak

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/lib/blkid/ChangeLog b/lib/blkid/ChangeLog
index 919fbb01f..4433ef413 100644
--- a/lib/blkid/ChangeLog
+++ b/lib/blkid/ChangeLog
@@ -1,3 +1,7 @@
+2007-03-23  Theodore Tso  <tytso@mit.edu>
+
+	* read.c (parse_dev): Fix memory leak on error path.
+
 2007-03-21  Theodore Tso  <tytso@mit.edu>
 
 	* resolve.c (blkid_get_devname): Fix memory leak.
diff --git a/lib/blkid/read.c b/lib/blkid/read.c
index 7a147f69d..583b54944 100644
--- a/lib/blkid/read.c
+++ b/lib/blkid/read.c
@@ -223,8 +223,10 @@ static int parse_dev(blkid_cache cache, blkid_dev *dev, char **cp)
 
 	DBG(DEBUG_READ, printf("found dev %s\n", name));
 
-	if (!(*dev = blkid_get_dev(cache, name, BLKID_DEV_CREATE)))
+	if (!(*dev = blkid_get_dev(cache, name, BLKID_DEV_CREATE))) {
+		free(name);
 		return -BLKID_ERR_MEM;
+	}
 
 	free(name);
 	return 1;