From: Takashi Sakamoto Date: Mon, 15 Sep 2025 23:47:47 +0000 (+0900) Subject: firewire: core: annotate fw_destroy_nodes with must-hold-lock X-Git-Tag: v6.18-rc1~159^2~14 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e0cda0dd12e08ecb8d26b8d78dc63e67e7069510;p=thirdparty%2Fkernel%2Flinux.git firewire: core: annotate fw_destroy_nodes with must-hold-lock The function, fw_destroy_nodes(), is used widely within firewire-core module. It has a prerequisite condition that struct fw_card.lock must be hold in advance. This commit adds annotation for it. Link: https://lore.kernel.org/r/20250915234747.915922-7-o-takashi@sakamocchi.jp Signed-off-by: Takashi Sakamoto --- diff --git a/drivers/firewire/core-topology.c b/drivers/firewire/core-topology.c index c62cf93f3f65e..8fa0772ee723f 100644 --- a/drivers/firewire/core-topology.c +++ b/drivers/firewire/core-topology.c @@ -325,9 +325,11 @@ static void report_found_node(struct fw_card *card, card->bm_retries = 0; } -/* Must be called with card->lock held */ void fw_destroy_nodes(struct fw_card *card) +__must_hold(&card->lock) { + lockdep_assert_held(&card->lock); + card->color++; if (card->local_node != NULL) for_each_fw_node(card, card->local_node, report_lost_node);