From: Stephen Finucane <stephen.finucane@intel.com>
Date: Sun, 19 Jun 2016 20:14:22 +0000 (+0100)
Subject: tests: Remove use of global value
X-Git-Tag: v2.0.0-rc1~327
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e105580f8c1605b696b009142825f7100798a50c;p=thirdparty%2Fpatchwork.git

tests: Remove use of global value

This isn't needed, so remove it.

Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Andy Doan <andy.doan@linaro.org>
---

diff --git a/patchwork/tests/utils.py b/patchwork/tests/utils.py
index 37478b6e..8bd02881 100644
--- a/patchwork/tests/utils.py
+++ b/patchwork/tests/utils.py
@@ -63,29 +63,29 @@ error_strings = {
     'email': 'Enter a valid email address.',
 }
 
-_user_idx = 1
-
 
 def create_user():
-    global _user_idx
-    userid = 'test%d' % _user_idx
-    email = '%s@example.com' % userid
-    _user_idx += 1
+    _user_id = User.objects.count()
+
+    username = 'test%d' % _user_id
+    email = '%s@example.com' % username
 
-    user = User.objects.create_user(userid, email, userid)
+    user = User.objects.create_user(username, email, username)
     user.save()
 
-    person = Person(email=email, name=userid, user=user)
+    person = Person(email=email, name=username, user=user)
     person.save()
 
     return user
 
 
 def create_maintainer(project):
+    """Create a 'User' and set as maintainer for provided project."""
     user = create_user()
     profile = user.profile
     profile.maintainer_projects.add(project)
     profile.save()
+
     return user