From: Miod Vallat <miod.vallat@powerdns.com>
Date: Thu, 4 Dec 2025 15:49:43 +0000 (+0100)
Subject: Logic buglet found during review.
X-Git-Tag: rec-5.4.0-alpha1~21^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e13f3db78c7acaa2cf87fa2beeaef6965c7251fa;p=thirdparty%2Fpdns.git

Logic buglet found during review.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
index 0ae6e2d6e9..a26c7c63cf 100644
--- a/pdns/ws-auth.cc
+++ b/pdns/ws-auth.cc
@@ -2678,7 +2678,7 @@ static void patchZone(UeberBackend& backend, const ZoneName& zonename, DomainInf
       {
         auto operationType2 = operationType == EXTEND ? PRUNE : operationType;
         if (seen.count({qname, qtype, operationType2}) != 0) {
-          if (operationType == EXTEND) {
+          if (operationType2 == PRUNE) {
             changetype = "EXTEND/PRUNE"; // for the sake of the error message
           }
           throw ApiException("Duplicate RRset " + qname.toString() + " IN " + qtype.toString() + " with changetype: " + changetype);