From: Michal Privoznik <mprivozn@redhat.com>
Date: Fri, 13 Apr 2012 09:19:29 +0000 (+0200)
Subject: conf: Avoid double assignment in virDomainDiskRemove
X-Git-Tag: v0.9.12-rc1~97
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e14d6571c1185133d15161bb4b18ec9b11192358;p=thirdparty%2Flibvirt.git

conf: Avoid double assignment in virDomainDiskRemove

Although it should be harmless to do:
    disk = disk = def->disks[i]
some not-so-wise compilers may fool around.
Besides, such assignment is useless here.
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index c6b97e1e52..a9c5cbce21 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -7124,7 +7124,7 @@ void virDomainDiskInsertPreAlloced(virDomainDefPtr def,
 virDomainDiskDefPtr
 virDomainDiskRemove(virDomainDefPtr def, size_t i)
 {
-    virDomainDiskDefPtr disk = disk = def->disks[i];
+    virDomainDiskDefPtr disk = def->disks[i];
 
     if (def->ndisks > 1) {
         memmove(def->disks + i,