From: Fabio Aiuto Date: Mon, 5 Apr 2021 16:49:54 +0000 (+0200) Subject: staging: rtl8723bs: place constant on the right side of the test X-Git-Tag: v5.13-rc1~173^2~216 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e153092677b9161c142580e9c0dd07cc64a7bc85;p=thirdparty%2Fkernel%2Fstable.git staging: rtl8723bs: place constant on the right side of the test fix following post-hook checkpatch issue: WARNING: Comparisons should place the constant on the right side of the test 85: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:676: + if (_FAIL == ret) Suggested-by: Joe Perches Signed-off-by: Fabio Aiuto Link: https://lore.kernel.org/r/8a6967abaef8b2edad6dc829dd232a7f048899d2.1617640221.git.fabioaiuto83@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index cec72abc983cf..5553246fa80b3 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -673,7 +673,7 @@ static u32 rtl8723bs_hal_init(struct adapter *padapter) /* rtw_hal_disable_interrupt(padapter); */ ret = _InitPowerOn_8723BS(padapter); - if (_FAIL == ret) + if (ret == _FAIL) return _FAIL; rtw_write8(padapter, REG_EARLY_MODE_CONTROL, 0);