From: Tim Wiederhake <twiederh@redhat.com>
Date: Thu, 9 Nov 2023 12:19:41 +0000 (+0100)
Subject: cpu_map: No longer ignore vmx- features in sync_qemu_features_i386.py
X-Git-Tag: v9.10.0-rc1~48
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e18075b27e6419c758a65348fddc3ae65e7542fc;p=thirdparty%2Flibvirt.git

cpu_map: No longer ignore vmx- features in sync_qemu_features_i386.py

Some guest OSes require cpu features from the vmx-* family,
e.g. vmx-xsaves. Up to now, libvirt ignored these features as they
were not required yet. qemu does not automatically enable e.g.
"vmx-xsaves" when requesting "xsaves":

    qmp="qemu-kvm -machine accel=kvm -nodefaults -nographic -qmp stdio"
    $(qmp) <<-EOF | jq | grep "xsaves"
    { "execute": "qmp_capabilities" }
    {
      "execute": "query-cpu-model-expansion",
      "arguments": {
        "type": "full",
        "model": {
          "name": "Skylake-Client-v1",
          "props": { "xsaves": true }   `# set to "true" or "false"`
        }
      }
    }
    { "execute": "quit" }
    EOF

with xsaves "false":
    "xsaves": false,
    "vmx-xsaves": false,

with xsaves "true":
    "xsaves": true,
    "vmx-xsaves": false,

Stop ignoring vmx-* features and begin adding them to libvirt's
database.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
---

diff --git a/src/cpu_map/sync_qemu_features_i386.py b/src/cpu_map/sync_qemu_features_i386.py
index 9e77d44bae..dcd58cd590 100755
--- a/src/cpu_map/sync_qemu_features_i386.py
+++ b/src/cpu_map/sync_qemu_features_i386.py
@@ -99,7 +99,7 @@ def ignore_feature(feature):
 
     name = feature["name"]
 
-    if name.startswith("x-") or name.startswith("vmx-"):
+    if name.startswith("x-"):
         return True
 
     if name in ignored_features: