From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Mon, 17 Jun 2019 06:05:54 +0000 (+0200)
Subject: vala: Only warn about imcompatible type of external construct property
X-Git-Tag: 0.45.2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e186c470fecc5f2d38a9711682be8b9fac1fdeca;p=thirdparty%2Fvala.git

vala: Only warn about imcompatible type of external construct property

This is to reduce the initial fallout.

Fixes https://gitlab.gnome.org/GNOME/vala/issues/803
---

diff --git a/vala/valapropertyaccessor.vala b/vala/valapropertyaccessor.vala
index 3c826737b..7603a0492 100644
--- a/vala/valapropertyaccessor.vala
+++ b/vala/valapropertyaccessor.vala
@@ -206,9 +206,14 @@ public class Vala.PropertyAccessor : Subroutine {
 			Report.error (source_reference, "construct properties require `GLib.Object'");
 			return false;
 		} else if (construction && !context.analyzer.is_gobject_property (prop)) {
-			error = true;
-			Report.error (source_reference, "construct properties not supported for specified property type");
-			return false;
+			//TODO Report an error for external property too
+			if (external_package) {
+				Report.warning (source_reference, "construct properties not supported for specified property type");
+			} else {
+				error = true;
+				Report.error (source_reference, "construct properties not supported for specified property type");
+				return false;
+			}
 		}
 
 		if (body != null && prop.is_abstract) {