From: Jason Ish <jason.ish@oisf.net>
Date: Mon, 26 Feb 2024 22:04:32 +0000 (-0600)
Subject: windows: remove argc, argv from SCServiceRemove
X-Git-Tag: suricata-8.0.0-beta1~1593
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e18779c1b4ea755a5e72bccbbeb1cab286d20b73;p=thirdparty%2Fsuricata.git

windows: remove argc, argv from SCServiceRemove

Not used.
---

diff --git a/src/suricata.c b/src/suricata.c
index 48c360506b..811cb07743 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -2349,7 +2349,7 @@ static int StartInternalRunMode(SCInstance *suri, int argc, char **argv)
             SCLogInfo("Suricata service has been successfully installed.");
             return TM_ECODE_DONE;
         case RUNMODE_REMOVE_SERVICE:
-            if (SCServiceRemove(argc, argv)) {
+            if (SCServiceRemove()) {
                 return TM_ECODE_FAILED;
             }
             SCLogInfo("Suricata service has been successfully removed.");
diff --git a/src/win32-service.c b/src/win32-service.c
index 0b7bd24e5f..cb90a4c512 100644
--- a/src/win32-service.c
+++ b/src/win32-service.c
@@ -279,7 +279,7 @@ int SCServiceInstall(int argc, char **argv)
  * \param argc num of arguments
  * \param argv passed arguments
  */
-int SCServiceRemove(int argc, char **argv)
+int SCServiceRemove(void)
 {
     SERVICE_STATUS status;
     SC_HANDLE service = NULL;
diff --git a/src/win32-service.h b/src/win32-service.h
index 24785d7556..87d4bc634e 100644
--- a/src/win32-service.h
+++ b/src/win32-service.h
@@ -28,7 +28,7 @@
 int SCRunningAsService(void);
 int SCServiceInit(int argc, char **argv);
 int SCServiceInstall(int argc, char **argv);
-int SCServiceRemove(int argc, char **argv);
+int SCServiceRemove(void);
 int SCServiceChangeParams(int argc, char **argv);
 #endif /* OS_WIN32 */