From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 24 Dec 2020 02:27:14 +0000 (-0800)
Subject: Don't use fr_sbuff_in_bstrcpy_buffer log messages may not be talloced
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e194e2be9e83713b0e123e4f427c6fb7cb976280;p=thirdparty%2Ffreeradius-server.git

Don't use fr_sbuff_in_bstrcpy_buffer log messages may not be talloced
---

diff --git a/src/lib/util/log.c b/src/lib/util/log.c
index 569bd9c64c6..042751e2e91 100644
--- a/src/lib/util/log.c
+++ b/src/lib/util/log.c
@@ -586,7 +586,7 @@ int fr_vlog_perror(fr_log_t const *log, fr_log_type_t type, char const *file, in
 			va_end(aq);
 
 			fr_sbuff_in_strcpy(&sbuff, ": ");
-			fr_sbuff_in_bstrcpy_buffer(&sbuff, error);
+			fr_sbuff_in_strcpy(&sbuff, error);	/* may not be talloced with const */
 			error = fr_sbuff_start(&sbuff);
 		}
 	/*
@@ -626,7 +626,7 @@ int fr_vlog_perror(fr_log_t const *log, fr_log_type_t type, char const *file, in
 	while ((error = fr_strerror_pop())) {
 		if (f_rules->subsq_prefix) {
 			fr_sbuff_set(&sbuff, &prefix_m);
-			fr_sbuff_in_bstrcpy_buffer(&sbuff, error);
+			fr_sbuff_in_strcpy(&sbuff, error);	/* may not be talloced with const */
 			error = fr_sbuff_start(&sbuff);
 		}