From: Stephan Bosch <stephan.bosch@dovecot.fi>
Date: Fri, 28 Sep 2018 11:17:30 +0000 (+0200)
Subject: lib-smtp: client: transaction: Annotate sub-parts of smtp_client_transaction_send_mor... 
X-Git-Tag: 2.3.9~1255
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e1985046c8c041a541e892b07d45087244ae66f7;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: client: transaction: Annotate sub-parts of smtp_client_transaction_send_more() with comments.
---

diff --git a/src/lib-smtp/smtp-client-transaction.c b/src/lib-smtp/smtp-client-transaction.c
index aadcbdfece..977bcf3685 100644
--- a/src/lib-smtp/smtp-client-transaction.c
+++ b/src/lib-smtp/smtp-client-transaction.c
@@ -736,11 +736,13 @@ smtp_client_transaction_submit_more(struct smtp_client_transaction *trans)
 
 	timeout_remove(&trans->to_send);
 
+	/* Check whether we already failed */
 	if (trans->failure != NULL) {
 		smtp_client_transaction_fail_reply(trans, trans->failure);
 		return;
 	}
 
+	/* Make sure transaction is started */
 	if (trans->state == SMTP_CLIENT_TRANSACTION_STATE_NEW) {
 		enum smtp_client_transaction_state state;
 		struct smtp_client_transaction *tmp_trans = trans;
@@ -756,6 +758,7 @@ smtp_client_transaction_submit_more(struct smtp_client_transaction *trans)
 	if (trans->state <= SMTP_CLIENT_TRANSACTION_STATE_PENDING)
 		return;
 
+	/* RCPT */
 	rcpt = array_get_modifiable(&trans->rcpts_pending, &count);
 	if (trans->rcpts_next_send_idx < count) {
 		unsigned int i;
@@ -782,6 +785,7 @@ smtp_client_transaction_submit_more(struct smtp_client_transaction *trans)
 		}
 	}
 
+	/* DATA */
 	if (trans->data_input != NULL)
 		smtp_client_transaction_send_data(trans);
 }