From: Otto Moerbeek Date: Fri, 19 Mar 2021 15:39:20 +0000 (+0100) Subject: Apply suggestions from code review X-Git-Tag: rec-4.5.0-beta1~5^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e19ca1ae26b1a167907dffd63bd3d781cfd35870;p=thirdparty%2Fpdns.git Apply suggestions from code review Co-authored-by: Remi Gacogne --- diff --git a/pdns/reczones.cc b/pdns/reczones.cc index 434ac53230..caae18954f 100644 --- a/pdns/reczones.cc +++ b/pdns/reczones.cc @@ -75,13 +75,13 @@ bool primeHints(time_t ignored) aset.push_back(arr); /* * Originally the hint records were inserted with the auth flag set, with the consequence that data from AUTHORITY and - * ADDITIONAL sections (as seen in a ,. NS response) were not used. This (together with the long ttl) caused outdated + * ADDITIONAL sections (as seen in a . NS response) were not used. This (together with the long ttl) caused outdated * hint to be kept in cache. So insert as non-auth, and the extra sections in the . NS refreshing cause the cached * records to be updated with up-to-date information received from a real root server. * * Note that if a user query is done for one of the root-server.net names, it will be inserted into the cache with the * auth bit set. Further NS refreshes will not update that entry. If all root names are queried at the same time by a user, - * all root-server.net names will be marked auth and will expired at the same time. A re-prime is then triggered, + * all root-server.net names will be marked auth and will expire at the same time. A re-prime is then triggered, * as before, when the records were inserted with the auth bit set and the TTD comes. */ g_recCache->replace(now, DNSName(templ), QType(QType::A), aset, vector>(), vector>(), false, g_rootdnsname, boost::none, boost::none, validationState, from); // auth, nuke it all