From: Jeremy Allison <jra@samba.org>
Date: Mon, 9 Apr 2018 16:32:23 +0000 (-0700)
Subject: s3: smbd: Unix extensions attempts to change wrong field in fchown call.
X-Git-Tag: samba-4.6.15~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e1c58ec4eed3479cb28f90b3982648dcf7cf88fb;p=thirdparty%2Fsamba.git

s3: smbd: Unix extensions attempts to change wrong field in fchown call.

Cut and paste error.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13375

Reported-by: Rungta, Vandana <vrungta@amazon.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Apr 10 00:45:56 CEST 2018 on sn-devel-144

(cherry picked from commit 3227b110d065500ed84fc70063da70ab35823a2e)

Autobuild-User(v4-6-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-6-test): Wed Apr 11 16:55:21 CEST 2018 on sn-devel-144
---

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index f0d8e7db55a..ec7a5fa99d5 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -7751,10 +7751,10 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn,
 
 		DEBUG(10,("smb_set_file_unix_basic: SMB_SET_FILE_UNIX_BASIC "
 			  "changing group %u for file %s\n",
-			  (unsigned int)set_owner,
+			  (unsigned int)set_grp,
 			  smb_fname_str_dbg(smb_fname)));
 		if (fsp && fsp->fh->fd != -1) {
-			ret = SMB_VFS_FCHOWN(fsp, set_owner, (gid_t)-1);
+			ret = SMB_VFS_FCHOWN(fsp, (uid_t)-1, set_grp);
 		} else {
 			/*
 			 * UNIX extensions calls must always operate