From: dklawren <dklawren@users.noreply.github.com>
Date: Fri, 15 May 2020 15:36:39 +0000 (-0400)
Subject: Bug 1638022 - Phabbugz should not try to set needs-review when the revision is closed... 
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e1cbdd805317095b05534c2f734f7084f88d83b3;p=thirdparty%2Fbugzilla.git

Bug 1638022 - Phabbugz should not try to set needs-review when the revision is closed or abandoned
---

diff --git a/extensions/PhabBugz/lib/Feed.pm b/extensions/PhabBugz/lib/Feed.pm
index baa887677..a3290fbbe 100644
--- a/extensions/PhabBugz/lib/Feed.pm
+++ b/extensions/PhabBugz/lib/Feed.pm
@@ -520,12 +520,14 @@ sub process_revision_change {
   }
 
   # Set status to request-review if revision is new and
-  # in draft state and not changes-planned
+  # in draft state and not changes-planned, closed, or abandoned.
   if ($is_new
       && $revision->status ne 'changes-planned'
+      && $revision->status ne 'closed'
+      && $revision->status ne 'abandoned'
       && ($revision->is_draft && !$revision->hold_as_draft))
   {
-    INFO("Moving from draft to needs-review");
+    INFO('Moving from draft to needs-review');
     $revision->set_status('request-review');
   }