From: hno <>
Date: Fri, 2 May 2003 15:57:54 +0000 (+0000)
Subject: SNMP correction to the returned type of
X-Git-Tag: SQUID_3_0_PRE1~217
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e1d20533b44c601dec9d194a5614027ccfbd184e;p=thirdparty%2Fsquid.git

SNMP correction to the returned type of

cacheNumObjCount: Gauge32
cacheCurrentUnlinkRequests: Gauge32
cacheCurrentSwapSize: Gauge32
cacheClients: Gauge32

All was Counter32 which is not correct for gauges.. Counter32 should only
be used for ever increasing counters. If unsure one of the Integer types
can be used, not Counter.
---

diff --git a/src/mib.txt b/src/mib.txt
index a9455e5c6b..1f3ea9afb9 100644
--- a/src/mib.txt
+++ b/src/mib.txt
@@ -2,7 +2,7 @@
 
 SQUID-MIB DEFINITIONS ::= BEGIN
 --
--- $Id: mib.txt,v 1.27 2003/02/14 22:47:46 hno Exp $
+-- $Id: mib.txt,v 1.28 2003/05/02 09:57:54 hno Exp $
 --
 
 IMPORTS
@@ -212,7 +212,7 @@ squid MODULE-IDENTITY
         ::= { cacheSysPerf 6 }
 
 	cacheNumObjCount OBJECT-TYPE
-                SYNTAX Counter32
+                SYNTAX Gauge32
 		MAX-ACCESS read-only
                 STATUS  current
                 DESCRIPTION
@@ -228,7 +228,7 @@ squid MODULE-IDENTITY
         ::= { cacheSysPerf 8 }
 
         cacheCurrentUnlinkRequests OBJECT-TYPE
-                SYNTAX Counter32
+                SYNTAX Gauge32
                 MAX-ACCESS read-only
                 STATUS current
 		DESCRIPTION
@@ -366,7 +366,7 @@ squid MODULE-IDENTITY
         ::= { cacheProtoAggregateStats 13 }
 
 	cacheCurrentSwapSize OBJECT-TYPE
-                SYNTAX Counter32
+                SYNTAX Gauge32
                 MAX-ACCESS read-only
                 STATUS current
 		DESCRIPTION
@@ -374,7 +374,7 @@ squid MODULE-IDENTITY
         ::= { cacheProtoAggregateStats 14 }
 
        cacheClients OBJECT-TYPE
-                SYNTAX Counter32
+                SYNTAX Gauge32
                 MAX-ACCESS read-only
                 STATUS current
 		DESCRIPTION
diff --git a/src/snmp_agent.cc b/src/snmp_agent.cc
index b5709a7102..8742e8e0cb 100644
--- a/src/snmp_agent.cc
+++ b/src/snmp_agent.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: snmp_agent.cc,v 1.87 2003/02/21 22:50:10 robertc Exp $
+ * $Id: snmp_agent.cc,v 1.88 2003/05/02 09:57:54 hno Exp $
  *
  * DEBUG: section 49     SNMP Interface
  * AUTHOR: Kostas Anagnostakis
@@ -343,7 +343,7 @@ snmp_prfSysFn(variable_list * Var, snint * ErrP)
     case PERF_SYS_CURUNLREQ:
         Answer = snmp_var_new_integer(Var->name, Var->name_length,
                                       (snint) statCounter.unlink.requests,
-                                      SMI_COUNTER32);
+                                      SMI_GAUGE32);
         break;
 
     case PERF_SYS_CURUNUSED_FD:
@@ -361,7 +361,7 @@ snmp_prfSysFn(variable_list * Var, snint * ErrP)
     case PERF_SYS_NUMOBJCNT:
         Answer = snmp_var_new_integer(Var->name, Var->name_length,
                                       (snint) StoreEntry::inUseCount(),
-                                      SMI_COUNTER32);
+                                      SMI_GAUGE32);
         break;
 
     default:
@@ -470,13 +470,13 @@ snmp_prfProtoFn(variable_list * Var, snint * ErrP)
         case PERF_PROTOSTAT_AGGR_CURSWAP:
             Answer = snmp_var_new_integer(Var->name, Var->name_length,
                                           (snint) store_swap_size,
-                                          SMI_COUNTER32);
+                                          SMI_GAUGE32);
             break;
 
         case PERF_PROTOSTAT_AGGR_CLIENTS:
             Answer = snmp_var_new_integer(Var->name, Var->name_length,
                                           (snint) statCounter.client_http.clients,
-                                          SMI_COUNTER32);
+                                          SMI_GAUGE32);
             break;
 
         default: