From: Hans de Goede Date: Fri, 9 Nov 2018 22:05:24 +0000 (+0100) Subject: ply-pixel-buffer: Fix marking buffers as opaque when doing a solid fill X-Git-Tag: 0.9.5~84^2~8 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e1e9e554d2014d80ce666d85174dbea89b05e038;p=thirdparty%2Fplymouth.git ply-pixel-buffer: Fix marking buffers as opaque when doing a solid fill Instead of comparing fill_area addresses actually compare the contents of the ply_rectangles. This allows us to use the memcpy fastpath in ply_pixel_buffer_with_buffer more often. Signed-off-by: Hans de Goede --- diff --git a/src/libply-splash-core/ply-pixel-buffer.c b/src/libply-splash-core/ply-pixel-buffer.c index 04aa0d66..86e8e3f0 100644 --- a/src/libply-splash-core/ply-pixel-buffer.c +++ b/src/libply-splash-core/ply-pixel-buffer.c @@ -315,7 +315,7 @@ ply_pixel_buffer_fill_area_with_pixel_value (ply_pixel_buffer_t *buffer, /* If we're filling the entire buffer with a fully opaque color, * then make note of it */ - if (fill_area == &buffer->area && + if (memcmp(fill_area, &buffer->area, sizeof(ply_rectangle_t)) == 0 && (pixel_value >> 24) == 0xff) { buffer->is_opaque = true; }