From: Björn Jacke <bj@sernet.de>
Date: Wed, 26 Dec 2018 00:01:14 +0000 (+0100)
Subject: readlink test: inverse return code
X-Git-Tag: tevent-0.12.0~681
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e225ab70db0cc01454d319eaca5265d7e33f396c;p=thirdparty%2Fsamba.git

readlink test: inverse return code

We need to return 0 in case readlink is *broken* here - this is because our waf
CHECK_CODE function does only allow generating defines in case the test succeeds

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13631

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/tests/readlink.c b/tests/readlink.c
index 65311c2ff79..a09eba4af2b 100644
--- a/tests/readlink.c
+++ b/tests/readlink.c
@@ -1,4 +1,7 @@
-/* test whether readlink returns a short buffer correctly. */
+/* test whether readlink returns a short buffer incorrectly.
+   We need to return 0 in case readlink is *broken* here - this is because our waf
+   CHECK_CODE function does only allow generating defines in case the test succeeds
+*/
 
 #if defined(HAVE_UNISTD_H)
 #include <unistd.h>
@@ -20,14 +23,14 @@ int main(void)
 	unlink(FNAME);
 	ret = symlink(DATA, FNAME);
 	if (ret == -1) {
-		exit(1);
+		exit(0);
 	}
 
 	rl_ret = readlink(FNAME, buf, sizeof(buf));
 	if (rl_ret == -1) {
 		unlink(FNAME);
-		exit(1);
+		exit(0);
 	}
 	unlink(FNAME);
-	exit(0);
+	exit(1);
 }